feat(richtext-lexical): add disableListColumn to lexicalHTMLField args #14235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainpi
force-pushed
the
feat-richtext-lexical-disableListColumn
branch
from
573d5c1 to
a8423de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Hello there!
Patch
A small patch that does two things:
lexicalHTMLFieldfrom the list columns (the same waylexicalHTMLFieldhasadmin.hiddenset to true by default).admin.disableListColumnto false (the same waylexicalHTMLFieldallows you to setadmin.hiddento false).Why
admin.disableListColumnfor the richtext field but not for the corresponding _html field.Suggestion
Suggestion: Adding the whole
admin: FieldAdminproperty tolexicalHTMLFieldsounds like a simple way to reduce redundancy and allow us to do things like show the field on the sidebar.